Re: [PATCH v8 5/8] drm/nouveau: Use hmm_range_fault_unlocked_timeout() for SVM faults

[Andrew Morton]

On Fri, 10 Jul 2026 14:26:58 -0700 Stanislav Kinsburskii 
<skinsburs...@gmail.com> wrote:

> @@ -683,15 +683,11 @@ static int nouveau_range_fault(struct nouveau_svmm 
> *svmm,
>                       goto out;
>               }
>  
> -             range.notifier_seq = mmu_interval_read_begin(range.notifier);
> -             mmap_read_lock(mm);
> -             ret = hmm_range_fault(&range);
> -             mmap_read_unlock(mm);
> -             if (ret) {
> -                     if (ret == -EBUSY)
> -                             continue;
> +             ret = hmm_range_fault_unlocked_timeout(&range,
> +                                                    max(timeout - jiffies,
> +                                                        1L));

"1UL" here?  I'd have expected min() to warn, as it likes to do.