Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] x86/hyperv: missing Fixes tag for commit 209954cbc7d0 --
commit b708a994017fe50fc481b9fcff6a341c5d843b13 Author: Naman Jain <[email protected]> > x86/hyperv: Filter TLB targets before building hypercalls > > SuperBench's eight-GPU PyTorch LSTM training on Azure MI300X VMs regressed > between Linux 6.8 and 7.0. Recreating DataLoader workers each epoch caused > host-to-GPU copy stalls and timeouts. The reported bisection identified > commit 209954cbc7d0 ("x86/mm/tlb: Update mm_cpumask lazily"). > > That change leaves a CPU's bit set after it switches to another mm. > Native flush callbacks remove these stale bits, but successful Hyper-V > hypercalls do not run those callbacks. A CPU actively running another > mm need not be in lazy TLB mode, so the existing lazy-TLB check does not > exclude it. If the mask includes all present CPUs, the backend selects > the all-processors shortcut before checking individual CPUs. > > Use the native predicate to build a per-CPU target mask before selecting > the all-processors shortcut or either hypercall format. Keep the full > candidate mask when freeing page tables. Retain the empty basic-mask > check because filtering can leave no targets. > > This patch does not change when trimming is requested. > > Signed-off-by: Naman Jain <[email protected]> [Severity: Low] Since this fixes the regression introduced by 209954cbc7d0 ("x86/mm/tlb: Update mm_cpumask lazily"), should the commit message include a Fixes tag? Fixes: 209954cbc7d0 ("x86/mm/tlb: Update mm_cpumask lazily") -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4
