Hi Jean,
>-----Original Message-----
>From: Jean Delvare [mailto:[email protected]]
>Sent: 2009年4月23日 17:30
>To: Wang, Wen W
>Cc: [email protected]
>Subject: Re: [PATCH 0/1] I2C: I2C controller driver for Intel Moorestown
>platform
>
>Hi Wen,
>
>On Thu, 23 Apr 2009 17:00:56 +0800, Wang, Wen W wrote:
>> Hi Jean,
>>
>> This is a description for the patch:
>> 1. Patch for I2C controller driver for Intel low power platform "Moorestown".
>> 2. The driver depends on a GPIO driver for Intel Moorestown platform.
>> 3. The patch will:
>> a. Add i2c_mrst.c and i2c_mrst.h to kernel directory
>> "drivers/i2c/busses"
>
>Why such a cryptic name? You know, this isn't MS-DOS, names can be
>longer than 8 characters ;)
:-) I can change the name to i2c_moorestown.c
>> b. Add items into kernel files "drivers/i2c/busses/Kconfig" and
>"drivers/i2c/Makefile".
>> c. Modify i2c-boardinfo.c to export i2c_register_board_info() function
>> and add
>code to detect if a device is already in i2c_board_list.
>
>This last item should go to a separate patch, so that it can be
I will separate the patch into two.
>discussed. It is not clear to me why you would need to export functions
>nobody else needed to export. It will be easier to review and merge
>your code if the bus driver itself is in one patch and any required
>integration changes are in another.
This is because:
1. The I2C driver need to call i2c_register_board_info() to register I2C device
info table when loaded.
2. To support loadable module, I made such change to i2c_register_board_info().
I know it’s quite ugly there, but I really can't find a way to do so. Please
feel free to teach me.
>Thanks,
>--
>Jean Delvare
BRs
Wen
N�Р骒r��y����b�X�肚�v�^�)藓{.n�+�伐�{��g"��^n�r■�z���h�ㄨ��&Ⅷ �G���h�(�����茛j"���m����赇z罐��帼f＂�h���~�m�
