On Tue, Feb 16, 2010 at 10:56:06AM +0100, Jean Delvare wrote: > On Mon, 15 Feb 2010 18:26:20 +0000, Jonathan Cameron wrote:
> > Can we change the name of data here. From readability point of view it > > would be better not to have this reliance on scope (as data used for > > struct i2c_smbus_alert *data above. (obviously changing it above would > > work as well!) > Oh, yeah, of course. Thanks for pointing this out. I wish we built the > kernel with -Wshadow so that gcc could tell us automatically... If you build with sparse (install it then add C=1 to the command line) it'll pick up shadowing along with all the other stuff. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
