Hi Jean, ----- "Jean Delvare" <[email protected]> a écrit :
> Hi Florian, > > On Wed, 18 Aug 2010 14:33:50 +0200, Florian Fainelli wrote: > > In case /dev/i2c is not a directory, open_i2c_dev will fail opening > > /dev/i2c/<i2cbus> but only handles the ENOENT errno, while we should > also > > handle ENOTDIR errno because this is the returned error code. The > patch > > attached fixes the issue. > > This is better discussed on the linux-i2c list. Redirecting... > > > Signed-off-by: Florian Fainelli <[email protected]> > > -- > > Index: tools/i2cbusses.c > > =================================================================== > > --- tools/.svn/text-base/i2cbusses.c.svn-base 2010-08-18 > 14:22:18.000000000 +0200 > > +++ /tmp/tempfile.2.tmp 2010-08-18 14:33:12.000000000 +0200 > > What a ugly header. How am I supposed to apply this? > > > @@ -378,7 +378,7 @@ > > sprintf(filename, "/dev/i2c/%d", i2cbus); > > file = open(filename, O_RDWR); > > > > - if (file < 0 && errno == ENOENT) { > > + if (file < 0 && (errno == ENOENT || errno == ENOTDIR)) { > > sprintf(filename, "/dev/i2c-%d", i2cbus); > > file = open(filename, O_RDWR); > > } > > > > I've never seen the case where /dev/i2c exists but isn't a directory > (which is why that case isn't handled.) How did you get in this > situation? It doesn't make much sense IMHO. Well, I got another driver here living at /dev/i2c which I am slowly migrating, but I would like to have i2cdetect working anyway ;) > > That being said, we can certainly apply your patch if it makes you > happy, I don't see it as being terribly useful, but it also shouldn't > hurt. I would be glad if you apply it. Thanks! -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
