Hi Joe, Thank you for your comments. We will update.
Thanks, Ohtake(OKISemi) ----- Original Message ----- From: "Joe Perches" <[email protected]> To: "Masayuki Ohtak" <[email protected]> Cc: "Jean Delvare (PC drivers, core)" <[email protected]>; "Ben Dooks (embedded platforms)" <[email protected]>; "Crane Cai" <[email protected]>; "Samuel Ortiz" <[email protected]>; "Linus Walleij" <[email protected]>; "Ralf Baechle" <[email protected]>; "srinidhi kasagar" <[email protected]>; <[email protected]>; <[email protected]>; "Wang Yong Y"" <[email protected]>; "Wang Qi"" <[email protected]>; "Andrew"" <[email protected]>; <[email protected]>; "Tomoya MORINAGA" <[email protected]>; "Arnd Bergmann" <[email protected]> Sent: Wednesday, September 01, 2010 11:43 AM Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35 > On Wed, 2010-09-01 at 11:26 +0900, Masayuki Ohtak wrote: > > I2C driver of Topcliff PCH > > +++ b/drivers/i2c/busses/i2c-pch.c > [] > > +static void pch_init(struct i2c_algo_pch_data *adap) > [] > > + if (pch_i2c_speed == FAST_MODE_CLK) { > > + reg_value |= FAST_MODE_EN; > > + dev_dbg(adap->pch_adapter.dev.parent, "Fast mode enabled\n"); > > + } > > Just a suggestion below, ignore it at your pleasure... > > These dev_<level> calls might be easier to read if you had > some #defines like: > > #define pch_dbg(adap, fmt, arg...) \ > dev_dbg(adap->pch_adapter.dev.parent, fmt, ##arg) > #define pch_err(adap, fmt, arg...) \ > dev_err(adap->pch_adapter.dev.parent, fmt, ##arg) > #define pch_info(adap, fmt, arg...) \ > dev_info(adap->pch_adapter.dev.parent, fmt, ##arg) > > then the last dev_dbg becomes: > > pch_dbg(adap, "Fast mode enabled\n"); > > Many modules use similar wrapper #defines. > > > + dev_dbg(adap->pch_adapter.dev.parent, > > + "%s: I2CCTL=%x pch_i2cbc=%x pch_i2ctmr=%x Enable interrupts\n", > > + __func__, ioread32(p + PCH_I2CCTL), > > + pch_i2cbc, pch_i2ctmr); > > pch_dbg(adap, etc...) > > etc. > > cheers, Joe > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
