On Mon, Sep 27, 2010 at 12:55:16PM +0200, Bernhard Walle wrote: > It doesn't make sense to set result to -ETIMEDOUT but return 0 (success) > afterwards. Since there's code in octeon_i2c_start() to handle the > error, it should be called. > > Signed-off-by: Bernhard Walle <[email protected]>
Acked-by: Wolfram Sang <[email protected]> but next time you should cc Ben Dooks to pick it up (i2c for embedded). > --- > drivers/i2c/busses/i2c-octeon.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c > index 0e9f85d..56dbe54 100644 > --- a/drivers/i2c/busses/i2c-octeon.c > +++ b/drivers/i2c/busses/i2c-octeon.c > @@ -218,7 +218,7 @@ static int octeon_i2c_wait(struct octeon_i2c *i2c) > return result; > } else if (result == 0) { > dev_dbg(i2c->dev, "%s: timeout\n", __func__); > - result = -ETIMEDOUT; > + return -ETIMEDOUT; > } > > return 0; > -- > 1.7.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
