On Mon, Dec 20, 2010 at 02:50:55PM +1100, Marc Reilly wrote:
> Signed-off-by: Marc Reilly <[email protected]>
> ---
> drivers/mfd/Kconfig | 22 ++++++++++++++--------
> drivers/mfd/Makefile | 2 ++
> 2 files changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 3a1493b..6980cf2 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -424,20 +424,26 @@ config MFD_PCF50633
> facilities, and registers devices for the various functions
> so that function-specific drivers can bind to them.
>
> -config MFD_MC13783
> - tristate
> -
this needs at least a note in the commit log. And $(git grep
MFD_MC13783 drivers) shows that you don't want to remove that yet.
> config MFD_MC13XXX
> - tristate "Support Freescale MC13783 and MC13892"
> - depends on SPI_MASTER
> + tristate "Support Freescale MC13XXX"
Hmm, I'd prefer to have the supported numbers. Consider FSL releasing
an MC13991. Then it's unclear if MFD_MC13XXX supports it.
> + depends on SPI_MASTER || I2C
> select MFD_CORE
> - select MFD_MC13783
> help
> Support for the Freescale (Atlas) PMIC and audio CODECs
> MC13783 and MC13892.
> - This driver provides common support for accessing the device,
> + This driver provides common support for accessing the device,
> additional drivers must be enabled in order to use the
> - functionality of the device.
> + functionality of these devices.
> +
> +config MFD_MC13XXX_SPI
> + tristate "Support for MC13XXX via SPI"
> + depends on SPI_MASTER
> + select MFD_MC13XXX
> +
> +config MFD_MC13XXX_I2C
> + tristate "Support for MC13XXX via I2C"
and only mc13892 can do i2c, so writing MC13XXX doesn't make sense here.
> + depends on I2C
> + select MFD_MC13XXX
Hmm, that means that MFD_MC13XXX alone doesn't do anything useful,
right? IMHO either do:
config MFD_MC13XXX_SPI
tristate
config MFD_MC13XXX_I2C
tristate
config MFD_MC13XXX
tristate "..."
select MFD_MC13XXX_SPI if SPI_MASTER
select MFD_MC13XXX_I2C if I2C
...
or
config MFD_MC13XXX
tristate
...
config MFD_MC13XXX_SPI
tristate "..."
select MFD_MC13XXX
...
config MFD_MC13XXX_I2C
tristate "..."
select MFD_MC13XXX
...
> config PCF50633_ADC
> tristate "Support for NXP PCF50633 ADC"
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index f54b365..b7d774f 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -42,6 +42,8 @@ obj-$(CONFIG_TWL4030_CODEC) += twl4030-codec.o
> obj-$(CONFIG_TWL6030_PWM) += twl6030-pwm.o
>
> obj-$(CONFIG_MFD_MC13XXX) += mc13xxx-core.o
> +obj-$(CONFIG_MFD_MC13XXX_SPI) += mc13xxx-spi.o
> +obj-$(CONFIG_MFD_MC13XXX_I2C) += mc13xxx-i2c.o
>
> obj-$(CONFIG_MFD_CORE) += mfd-core.o
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
