On Wednesday, December 22, 2010, Mark Brown wrote: > On Wed, Dec 22, 2010 at 08:40:23PM +0530, Rabin Vincent wrote: > > > Shouldn't you be deleting the pm_runtime_* stuff from here? There is > > already done in pm_generic_restore() iff the callback exists and returns > > zero. > > I guess; it's not clear why this is being done by the bus at all or how > it interacts with the legacy stuff.
It is done, because when the driver's ->resume() or ->restore() brings the device up (which should have happened if it returned 0), we need to mark the device as "active" for runtime PM. Since __pm_generic_resume() does that, it's not necessary to do it in the bus type callbacks (in the "legacy" case we known that runtime PM is not supported). Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
