Hi Guenter,
On Thu, 27 Jan 2011 11:58:42 -0800, Guenter Roeck wrote:
> Add support to write SMBus and I2C block data to i2cset.
>
> Rev 2: Included review feedback
Two remaining minor issues:
> @@ -78,6 +80,19 @@
> return -1;
> }
> break;
> +
> + case I2C_SMBUS_BLOCK_DATA:
> + if (!(funcs & I2C_FUNC_SMBUS_WRITE_BLOCK_DATA)) {
> + fprintf(stderr, MISSING_FUNC_FMT, "SMBus block read");
"SMBus block write"
> + return -1;
> + }
> + break;
> + case I2C_SMBUS_I2C_BLOCK_DATA:
> + if (!(funcs & I2C_FUNC_SMBUS_WRITE_I2C_BLOCK)) {
> + fprintf(stderr, MISSING_FUNC_FMT, "I2C block read");
"I2C block write"
> + return -1;
> + }
> + break;
> }
>
> if (pec
Other than that, it looks alright, feel free to commit (I've just added
you to the list of committers - same credentials as lm-sensors
repository.)
Next, I think we can remove the old method for setting the mask. Then
we'll see if some code cleanup or reorganization makes sense.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
