On Wed, Feb 16, 2011 at 9:37 AM, Stephen Warren <[email protected]> wrote: > On 08/02/11 12:44, Mark Brown wrote: >> ... >> + goto err_iounmap; >> + } >> + irq = res->start; >> + >> + clk = clk_get(&pdev->dev, NULL); >> + if (!clk) { > > This should be: > > if (!IS_ERR(clk)) { Just if (IS_ERR(clk))
>> + ret = -ENOMEM; > > This should probably be: > > ret = PTR_ERR(clk); Yes > although Ben made some comments in his review re: certain error codes being > ignored by the higher layers; I'm not sure if that applies here or not. The clkdev clk_get implementation returns -ENOENT, so it should be OK. >> + goto err_release_region; >> + } >> + > > -- > nvpublic > > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
