On Thu, Nov 24, 2011 at 09:37:47AM +0100, Wolfram Sang wrote: > On Thu, Nov 24, 2011 at 09:29:03AM +0100, Uwe Kleine-König wrote: > > Hello Shawn, > > > > On Thu, Nov 24, 2011 at 03:52:20PM +0800, Shawn Guo wrote: > > > CC drivers/i2c/busses/i2c-mxs.o > > > drivers/i2c/busses/i2c-mxs.c: In function ‘mxs_i2c_xfer’: > > > drivers/i2c/busses/i2c-mxs.c:196:6: warning: ‘data’ may be used > > > uninitialized in this function > > > > > > Signed-off-by: Shawn Guo <[email protected]> > > > --- > > > drivers/i2c/busses/i2c-mxs.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c > > > index 7e78f7c..00f098f 100644 > > > --- a/drivers/i2c/busses/i2c-mxs.c > > > +++ b/drivers/i2c/busses/i2c-mxs.c > > > @@ -193,7 +193,7 @@ static int mxs_i2c_wait_for_data(struct mxs_i2c_dev > > > *i2c) > > > > > > static int mxs_i2c_finish_read(struct mxs_i2c_dev *i2c, u8 *buf, int len) > > > { > > > - u32 data; > > > + u32 data = 0; > > > int i; > > > > > > for (i = 0; i < len; i++) { > > Looks like a stupid compiler. Then better use > > > > u32 uninitialized_var(data); > > Leave it as it is and fix the compiler? Will do another test later to make > sure. > Ben, do you have an opinion on this, leave it there or fix it?
-- Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
