On Sat, Jan 21, 2012 at 05:10:22PM +0100, Sylwester Nawrocki wrote: > On 01/21/2012 02:28 PM, Mark Brown wrote: > > Saves remembering to call kfree(). There's some kfree()s used by the > > resource still, these will be removed in 3.3 using the newly added > > devm_request_and_ioremap(). > > > > Signed-off-by: Mark Brown Mark Brown<[email protected]> > > --- > > drivers/i2c/busses/i2c-s3c2410.c | 4 +--- > > 1 files changed, 1 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-s3c2410.c > > b/drivers/i2c/busses/i2c-s3c2410.c > > index 4c17180..e6f982b 100644 > > --- a/drivers/i2c/busses/i2c-s3c2410.c > > +++ b/drivers/i2c/busses/i2c-s3c2410.c > > @@ -890,7 +890,7 @@ static int s3c24xx_i2c_probe(struct platform_device > > *pdev) > > } > > } > > > > - i2c = kzalloc(sizeof(struct s3c24xx_i2c), GFP_KERNEL); > > + i2c = devm_kzalloc(&pdev->dev, sizeof(struct s3c24xx_i2c), GFP_KERNEL); > > Just in case you are resending the patch for any other reason, it might be > worth > to change to sizeof(*i2c) for consistency.
Yuck. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
