On Sun, May 27, 2012 at 04:10:56AM +0200, Marek Vasut wrote:
> This patch implements DMA support into mxs-i2c. DMA transfers are now enabled
> via DT. The DMA operation is enabled by default.
>
> Signed-off-by: Marek Vasut <[email protected]>
> Cc: Detlev Zundel <[email protected]>
> CC: Dong Aisheng <[email protected]>
> CC: Fabio Estevam <[email protected]>
> Cc: Linux ARM kernel <[email protected]>
> Cc: [email protected]
> CC: Sascha Hauer <[email protected]>
> CC: Shawn Guo <[email protected]>
> Cc: Stefano Babic <[email protected]>
> CC: Uwe Kleine-König <[email protected]>
> Cc: Wolfgang Denk <[email protected]>
> Cc: Wolfram Sang <[email protected]>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mxs.txt | 3 +
> arch/arm/boot/dts/imx28.dtsi | 2 +
> drivers/i2c/busses/i2c-mxs.c | 268
> +++++++++++++++++++--
> 3 files changed, 251 insertions(+), 22 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mxs.txt
> b/Documentation/devicetree/bindings/i2c/i2c-mxs.txt
> index 790b5c6..f4b6244 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mxs.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mxs.txt
> @@ -6,6 +6,9 @@ Required properties:
> - interrupts: Should contain ERROR and DMA interrupts
> - speed: Speed of the bus in kHz (400 or 100 are supported)
>
> +Optional properties:
> +- use-pio: Use PIO transfers instead of DMA, useful for debug
It should be "fsl,use-pio" which is the one used in code?
> +
> Examples:
>
> i2c0: i2c@80058000 {
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index d927155..d470276 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -381,6 +381,7 @@
> compatible = "fsl,imx28-i2c";
> reg = <0x80058000 2000>;
> interrupts = <111 68>;
> + fsl,i2c-dma-channel = <6>;
You may need to document this property in binding doc as well.
> fsl,speed = <400>;
> status = "disabled";
> };
> @@ -391,6 +392,7 @@
> compatible = "fsl,imx28-i2c";
> reg = <0x8005a000 2000>;
> interrupts = <110 69>;
> + fsl,i2c-dma-channel = <7>;
> fsl,speed = <400>;
> status = "disabled";
> };
--
Regards,
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
