Hi Amaury, On Fri, 4 Jan 2013 12:44:00 +0100, Amaury Decrême wrote: > On Thu, Oct 04, 2012 at 05:29:39PM +0200, Jean Delvare wrote: > > This is a mask, would be good to make it visible in the name. OTOH the > > masking is a no-op in practice so I'm not sure it's worth defining. > > I removed it. I understand that byte mask shouldn't be keeped but bit mask is > ok. > Is it the right logic ?
No, my point is that masking operations which will always resolve to no-ops by construct should be avoided. The compiler may not always be able to optimize these out. This hold for both single and multi-bit masking. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
