Dear Fabio Estevam, > From: Fabio Estevam <[email protected]> > > cmd_err is used to handle error code, so it should not be unsigned. > > This fixes the following warning when building with W=1 option: > > drivers/i2c/busses/i2c-mxs.c: In function 'mxs_i2c_xfer_msg': > drivers/i2c/busses/i2c-mxs.c:331:19: warning: comparison between signed and > unsigned integer expressions [-Wsign-compare] > > Signed-off-by: Fabio Estevam <[email protected]>
Amazing catch Acked-by: Marek Vasut <[email protected]> Can this also go to -stable 3.7 ? > --- > drivers/i2c/busses/i2c-mxs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c > index 1b1a936..621153a 100644 > --- a/drivers/i2c/busses/i2c-mxs.c > +++ b/drivers/i2c/busses/i2c-mxs.c > @@ -127,7 +127,7 @@ struct mxs_i2c_dev { > struct device *dev; > void __iomem *regs; > struct completion cmd_complete; > - u32 cmd_err; > + int cmd_err; > struct i2c_adapter adapter; > const struct mxs_i2c_speed_config *speed; Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
