On Tue, Apr 09, 2013 at 09:07:10AM +0900, Jingoo Han wrote: > On Friday, March 22, 2013 8:47 PM, Wolfram Sang wrote: > > > > On Fri, Mar 22, 2013 at 11:13:07AM +0900, Jingoo Han wrote: > > > Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following > > > build warning when CONFIG_PM_SLEEP is not selected. This is because > > > sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when > > > the CONFIG_PM_SLEEP is enabled. > > > > > > drivers/i2c/busses/i2c-designware-platdrv.c:253:12: warning: > > > 'dw_i2c_suspend' defined but not used [- > > Wunused-function] > > > drivers/i2c/busses/i2c-designware-platdrv.c:263:12: warning: > > > 'dw_i2c_resume' defined but not used [- > > Wunused-function] > > > > > > Signed-off-by: Jingoo Han <[email protected]> > > > > What about doing it like the s3c2410 driver which also adds CONFIG_PM > > around the whole structure? (comment applies for both patches) > > Hi Wolfram Sang, > Sorry for being late. > > It is similar with s3c2410 driver. > However, CONFIG_PM is not necessary, when only SIMPLE_DEV_PM_OPS is > used.
Still, you are always creating a dev_pm_ops structure, even if empty in case of no CONFIG_PM. The s3c driver skips that and uses NULL for setting the pm member of the driver struct then. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
