On Thu, 16 May 2013 21:33:09 +0100 Russell King <[email protected]> wrote:
> Eliminate reg_base_p and reg_size, mv64xxx_i2c_unmap_regs() and an > unchecked ioremap() return from this driver by using the devm_* > API for requesting and ioremapping resources. > > Signed-off-by: Russell King <[email protected]> > --- > drivers/i2c/busses/i2c-mv64xxx.c | 46 > +++++--------------------------------- > 1 files changed, 6 insertions(+), 40 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-mv64xxx.c > b/drivers/i2c/busses/i2c-mv64xxx.c > index 0339cd8..19cc9bf 100644 > --- a/drivers/i2c/busses/i2c-mv64xxx.c > +++ b/drivers/i2c/busses/i2c-mv64xxx.c [snip] > @@ -704,7 +671,6 @@ mv64xxx_i2c_remove(struct platform_device *dev) > > rc = i2c_del_adapter(&drv_data->adapter); > free_irq(drv_data->irq, drv_data); > - mv64xxx_i2c_unmap_regs(drv_data); > #if defined(CONFIG_HAVE_CLK) > /* Not all platforms have a clk */ > if (!IS_ERR(drv_data->clk)) { The patch does not apply: it seems it lacks: + int rc; - i2c_del_adapter(&drv_data->adapter); + rc = i2c_del_adapter(&drv_data->adapter); - return 0; + return rc; BTW, is this return code useful? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
