On Tuesday, December 17, 2013 4:53 PM, Jean Delvare wrote: > On Tue, 17 Dec 2013 15:51:28 +0900, Jingoo Han wrote: > > Use devm_request_region() to make cleanup paths simpler. > > You need to include <linux/ioport.h> for this function.
According to the i2c tree, <linux/ioport.h> is already included. :-) ./ drivers/i2c/busses/i2c-isch.c #include <linux/module.h> #include <linux/platform_device.h> #include <linux/kernel.h> #include <linux/delay.h> #include <linux/stddef.h> #include <linux/ioport.h> <-- Here! > > > Signed-off-by: Jingoo Han <[email protected]> > > --- > > drivers/i2c/busses/i2c-isch.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) [.....] > > @@ -307,7 +307,6 @@ static int smbus_sch_remove(struct platform_device > > *pdev) > > if (sch_smba) { > > i2c_del_adapter(&sch_adapter); > > res = platform_get_resource(pdev, IORESOURCE_IO, 0); > > - release_region(res->start, resource_size(res)); > > sch_smba = 0; > > } > > "res" becomes useless in the remove function as you removed the only > use of it. So you can simplify this function further. OK, you're right. I will remove tge unnecessary "res" variable. I will send V2 patch, soon. Thank you for your comment. :-) Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
