Hi Ezequiel,

> From: James Hogan <[email protected]>
>
> Introduce a devicetree binding for Imagination Technologies
> I2C SCB controller.
>
> Signed-off-by: James Hogan <[email protected]>

This should have your S-o-B as well.

> diff --git a/Documentation/devicetree/bindings/i2c/i2c-img-scb.txt 
> b/Documentation/devicetree/bindings/i2c/i2c-img-scb.txt

> @@ -0,0 +1,14 @@
> +IMG Serial Control Bus (SCB) I2C Controller
> +
> +Required Properties:
> +- compatible: "img,scb-i2c"

Is there no difference between the controller present on TZ1090 and Pistachio?

> +- reg: Physical base address and length of controller registers
> +- interrupts: Interrupt number used by the controller
> +- clocks : Clock specifier to the SCB clock node

On Pistachio there are two clocks per controller, the I2C operating
clock and I2C "system" clock (which I assume is the system interface
gate clock).  There should also be a "clock-names" property with an
entry for each clock.

> +- clock-frequency: The I2C bus frequency in Hz
> +- bus-delay : Bus delay in ms

Probably should list #address-cells and #size-cells here as well.

> +Optional properties:
> +- linux,i2c-index: Can be used to override the I2C bus number. This is useful
> +  when some of the I2C adapters are used by other non-Linux cores so would 
> get
> +  numbered incorrectly by default.

I don't think this is necessary.  Aliases can be used to set the
adapter number instead.

Also, it's generally good to include an example node.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to