Hi Wolfram, On Wed, Dec 10, 2014 at 2:21 PM, Wolfram Sang <[email protected]> wrote: > DMA is opt-in for this driver. So, we can't use deferred probing in > probe, because our driver would get endlessly deferred if DMA support is > compiled in but only the DMA driver is missing. Because we can't know > when the DMA driver might show up, we always try again when a DMA > transfer would be possible. The downside is that there is more overhead > for setting up every DMA transfer.
... for setting up every PIO transfer? Once DMA is available, it's just one extra variable check. > Reported-by: Geert Uytterhoeven <[email protected]> > Signed-off-by: Wolfram Sang <[email protected]> > --- > drivers/i2c/busses/i2c-sh_mobile.c | 98 > +++++++++++++++++++------------------- > 1 file changed, 48 insertions(+), 50 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-sh_mobile.c > b/drivers/i2c/busses/i2c-sh_mobile.c > index 636f2297143a..ea7b99212fa6 100644 > --- a/drivers/i2c/busses/i2c-sh_mobile.c > +++ b/drivers/i2c/busses/i2c-sh_mobile.c > @@ -144,6 +144,7 @@ struct sh_mobile_i2c_data { > int sr; > bool send_stop; > > + struct resource *res; I thinkk you can just store dma_addr_t port_addr here. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
