From: Philipp Zabel <[email protected]> Sent: Wednesday, January 07, 2015 7:02 PM > To: Duan Fugang-B38611 > Cc: Wolfram Sang; Estevam Fabio-R49496; [email protected]; > [email protected]; Yuan Yao-B46683 > Subject: Re: [PATCH 3/3] i2c: imx: whitespace and checkpatch cleanup > > Hi Andy, > > Am Mittwoch, den 07.01.2015, 02:36 +0000 schrieb > [email protected]: > > From: Philipp Zabel <[email protected]> > > Sent: Tuesday, January 06, 2015 10:48 PM > > > To: Wolfram Sang > > > Cc: [email protected]; Duan Fugang-B38611; Yuan Yao-B46683; > > > Estevam Fabio-R49496; [email protected]; Philipp Zabel > > > Subject: [PATCH 3/3] i2c: imx: whitespace and checkpatch cleanup > > > > > > This patch fixes up some whitespace issues and addresses a few > > > checkpatch warnings. > > > > > > Signed-off-by: Philipp Zabel <[email protected]> > > > --- > > > drivers/i2c/busses/i2c-imx.c | 53 > > > ++++++++++++++++++++++++++------------ > > > ------ > > > 1 file changed, 32 insertions(+), 21 deletions(-) > > > > [snip] > > > if (i == (msgs->len - 1)) { > > > if (is_lastmsg) { > > > /* > > > - * It must generate STOP before read I2DR to > > > prevent > > > - * controller from generating another clock > > > cycle > > > + * It must generate STOP before read I2DR to > > > + * prevent controller from generating another > > > + * clock cycle > > > */ > > > > It is better for the format: > > /* It must generate STOP before read I2DR to > > Thank you for the review, but according to Documentation/CodingStyle this > multi-line comment format is only preferred for code in net/ and > drivers/net. > > regards > Philipp
I agree. So I am fine for the patch. Thanks for your code clean. Acked-by: Fugang Duan <[email protected]> Regards, Andy N�����r��y����b�X��ǧv�^�){.n�+����{��g"��^n�r���z���h�����&�� �G���h�(�階�ݢj"���m������z�ޖ���f���h���~�m�
