On Mon, 09 Feb 2015, Wolfram Sang wrote: > On Sun, Feb 08, 2015 at 08:12:35AM -0500, Nicholas Mc Guire wrote: > > Return type of wait_for_completion_timeout is unsigned long not int. ret in > > img_i2c_reset_bus() was exclusively used for wait_for_completion_timeout so > > its type is simply adjusted. In img_i2c_xfer an appropriately typed variable > > is added and assignment fixed up. > > > > Signed-off-by: Nicholas Mc Guire <[email protected]> > > Same as for the axxia driver: Please rename the variable because ret > being an int is kind of an idiom. > added "don't break idioms" to my list of Checks - maybe something like this even should be in SubmittingPatches ?
will fix up and resend. thx! hofrat -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
