The i2c-gpio driver can be used in systems where the GPIO itself is provided by a GPIO driver that may be sleeping (for example, SPI or USB). In this case, it is preferable to use the _cansleep() variants of the GPIO code.
We can only fix this up for the case where the i2c-gpio implementation provides open-drain outputs as there are no gpio_direction_xxx_cansleep() provided. This removes the issues on the customer system with the console constantly showing the following warning: WARNING: CPU: 0 PID: 1 at drivers/gpio/gpiolib.c:2389 gpiod_set_raw_value Signed-off-by: Ben Dooks <[email protected]> -- CC: Haavard Skinnemoen <[email protected]> CC: Wolfram Sang <[email protected]> CC: [email protected] --- drivers/i2c/busses/i2c-gpio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c index d1050bd..9d4d59c 100644 --- a/drivers/i2c/busses/i2c-gpio.c +++ b/drivers/i2c/busses/i2c-gpio.c @@ -44,7 +44,7 @@ static void i2c_gpio_setsda_val(void *data, int state) { struct i2c_gpio_platform_data *pdata = data; - gpio_set_value(pdata->sda_pin, state); + gpio_set_value_cansleep(pdata->sda_pin, state); } /* Toggle SCL by changing the direction of the pin. */ @@ -68,21 +68,21 @@ static void i2c_gpio_setscl_val(void *data, int state) { struct i2c_gpio_platform_data *pdata = data; - gpio_set_value(pdata->scl_pin, state); + gpio_set_value_cansleep(pdata->scl_pin, state); } static int i2c_gpio_getsda(void *data) { struct i2c_gpio_platform_data *pdata = data; - return gpio_get_value(pdata->sda_pin); + return gpio_get_value_cansleep(pdata->sda_pin); } static int i2c_gpio_getscl(void *data) { struct i2c_gpio_platform_data *pdata = data; - return gpio_get_value(pdata->scl_pin); + return gpio_get_value_cansleep(pdata->scl_pin); } static int of_i2c_gpio_get_pins(struct device_node *np, -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
