On Saturday 30 May 2015 03:12 AM, Robert Jarzmik wrote:
Vaibhav Hiremath <[email protected]> writes:

Update i2c_pxa_scream_blue_murder() fn to print more information
in case of error.

Signed-off-by: Jett.Zhou <[email protected]>
[[email protected]: Split patches into logical changes
and update the Changelog]
Signed-off-by: Vaibhav Hiremath <[email protected]>
Cc: Wolfram Sang <[email protected]>

Signed-off-by: Vaibhav Hiremath <[email protected]>
---
  drivers/i2c/busses/i2c-pxa.c | 11 ++++++++---
  1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index cf6c383..065e647 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -147,6 +147,7 @@ struct pxa_i2c {
        unsigned int            msg_idx;
        unsigned int            msg_ptr;
        unsigned int            slave_addr;
+       unsigned int            req_slave_addr;

        struct i2c_adapter      adap;
        struct clk              *clk;
@@ -335,11 +336,13 @@ err_out:
  static void i2c_pxa_scream_blue_murder(struct pxa_i2c *i2c, const char *why)
  {
        unsigned int i;
-       printk(KERN_ERR "i2c: error: %s\n", why);
+       printk(KERN_ERR"i2c: <%s> slave_0x%x error: %s\n", i2c->adap.name,
+               i2c->req_slave_addr >> 1, why);
Why not simply use dev_err(....) instead of adding manually i2c->adap.name ?


Actually I missed this. Thought of fixing this, but somehow forgot :)
Will fix it in next version.

Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to