Re: [PATCHv2 6/9] i2c: xiic: Add a debug msg in case of timeout

Thu, 09 Jul 2015 22:12:12 -0700 

On Thu, Jul 9, 2015 at 10:59 PM, Wolfram Sang <[email protected]> wrote:
> On Wed, Jun 17, 2015 at 08:48:16PM +0530, Shubhrajyoti Datta wrote:
>> Currently we return silently upon a timeout.
>> Adding an error message to aid debugability. Not
>>  a functional change.
>>
>> Signed-off-by: Shubhrajyoti Datta <[email protected]>
>
> I am not in favour of this. In case of a stalled bus, this can easily
> flood the logs. If it is for debugging, it should also be dev_dbg. And
> then, it probably can also be added when needed. I mean the errno is
> quite descriptive, no?
>
I agree I had added it for debugging.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to