On Tue, Sep 08, 2015 at 11:05:49AM +0200, Jean Delvare wrote: > The ioctl is named I2C_RDWR for "I2C read/write". But references to it > were misspelled "rdrw". Fix them. > > Signed-off-by: Jean Delvare <jdelv...@suse.de> > Cc: Wolfram Sang <w...@the-dreams.de>
Wow! Amazing how long this went unnoticed/unfixed. > -#define I2C_RDRW_IOCTL_MAX_MSGS 42 > +#define I2C_RDWR_IOCTL_MAX_MSGS 42 > +/* Originally defined with a typo, keep if for now for compatibility */ I would drop the 'for now' and keep it forever. A define doesn't hurt and if it increases backwards compatibility, why not? I will also do s/if/it/. No need to resend. > +#define I2C_RDRW_IOCTL_MAX_MSGS I2C_RDWR_IOCTL_MAX_MSGS Thanks!
signature.asc
Description: Digital signature