> -#include "xtalk/xwidgetdev.h"
> +#include <asm/sn/xtalk/xwidgetdev.h>
> #include <asm/sn/geo.h>
> -#include "xtalk/hubdev.h"
> +#include <asm/sn/xtalk/hubdev.h>
please put moving around headers in a separate patch.
> DEFINE_PER_CPU(struct pda_s, pda_percpu);
> +EXPORT_PER_CPU_SYMBOL(pda_percpu);
As mentioned the last time you posted it please use a proper accessor.
> +static void tiocx_bus_release(struct device *dev)
> +{
> +}
this is broken. See the tweleve gazillion times it came up on lkml.
The driver core doesn't warn about the lack of a release function because
it's a nice way to waste time but because there's an actual reason.
> +struct cx_drv {
> + char *name;
> + const struct cx_device_id *id_table;
> + struct device_driver driver;
> + int (*probe) (struct cx_dev * dev, const struct cx_device_id * id);
> +};
To make it work sanely you also need a ->remove callout.
With the above issues fixed it's fine to be queued up until you submit
an actual user of this interface.
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
