On Tue, Mar 01, 2005 at 11:23:21AM -0800, David Mosberger wrote: > >>>>> On Sat, 26 Feb 2005 08:25:41 -0600, Robin Holt <[EMAIL PROTECTED]> said: > > Robin> Tony, This patch introduces using the quicklists for pgd, > Robin> pmd, and pte levels by combining the alloc and free functions > Robin> into a common set of routines. This greatly simplifies the > Robin> reading of this header file. > > Agreed, but now you implicitly assume that the directories at all > levels are the same size. I think it would be better to pass the > desired size to the alloc routine such that you can at least fail > noisily if somebody ever tried to use different-size directories.
Can I skip this for now? The old code assumed a page size allocation as does the new. When I go to implement the 4-level page tables, we can come back and address this concern then. > > Robin> Before: > Robin> Process fork+exit: 255.0909 microseconds > > Robin> After: > Robin> Process fork+exit: 184.2333 microseconds > > Nice. > > Robin> + ret = local_cpu_data->pgtable_quicklist; > > Is there any reason pgtable_quicklist isn't a normal per-CPU variable? > We didn't use to have that facility, that's why we used to keep it in > local_cpu_data, but noadays, there should be no need for that ugly > hack. > > Since this is performance-critical, it's probably worthwhile to use > __ia64_per_cpu_var() to access the quicklist. That way, the address > of pgtable_quicklist can be obtained with a single "addl" instruction. I made this change. One thing I noticed is in contig.c and discontig.c, we print out the number of pages in the quicklists. Should I be totalling that for all cpus and printing the summation? Is there a better way than for_each_online_cpu() (or whatever it is called)? Thanks, Robin - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
