> + extern nasid_t master_nasid;
please put externs always in headers (that are included by the file
defining the blobal symbol, too)
> +#include "snsc.h"
> +#include <asm/sn/sn_sal.h>
> +#include <linux/interrupt.h>
> +#include <linux/sched.h>
header ordering is <linux/*.h> first, then <asm/*.h>, then local
headers.
> +scdrv_event_interrupt(int irq, void *subch_data, struct pt_regs *regs)
> +{
> + struct subch_data_s *sd = (struct subch_data_s *) subch_data;
no need to cast.
> +static unsigned int
> +scdrv_buffer_to_int(char *buf)
> +{
> + int i;
> + unsigned int n = 0;
> + for( i = 0; i < sizeof(n); i++ ) {
> + n |= ((unsigned)(*(unsigned char *)buf++)
> + << (8 * ((sizeof(n) - i) - 1)));
urgg. the (*(unsigned char *)buf++) should be just *(buf++), no?
address arithmetics on signed and unsigned char are the same.
So
for (i = 0; i < sizeof(n); i++)
n |= ((unsigned int)buf[i] << (8 * (sizeof(n) - i - 1)));
should do the same, no?
> + event_sd = (struct subch_data_s *) kmalloc
> + (sizeof (struct subch_data_s), GFP_KERNEL);
no need to cast
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
