Re: [patch 1/1] printk : arch/ia64/kernel/smp.c

[Christophe Lucas]

Luck, Tony ([EMAIL PROTECTED]) wrote:
> >     if (cpuid == me) {
> >-            printk("%s: trying to call self\n", __FUNCTION__);
> >+            printk(KERN_INFO "%s: trying to call self\n", __FUNCTION__);
> >             put_cpu();
> >             return -EBUSY;
> >     }
> 
> I think this is a bit higher priority than KERN_INFO.  If we
> get here, then someone did something wrong at a higher level,
> and they may be disapponited that the function they want called
> isn't going to be called.
> 
> Perhaps KERN_WARNING would be more appropriate?
> 
> It might also be kind to anyone trying to debug this to print
> the "func" argument.
> 
> -Tony
> 

Perhaps this could do the job:



diff -uprN -X dontdiff a/arch/ia64/kernel/smp.c b/arch/ia64/kernel/smp.c
--- a/arch/ia64/kernel/smp.c    2005-03-18 02:34:36.000000000 +0100
+++ b/arch/ia64/kernel/smp.c    2005-03-23 10:35:18.000000000 +0100
@@ -269,7 +269,7 @@ smp_call_function_single (int cpuid, voi
        int me = get_cpu(); /* prevent preemption and reschedule on another 
processor */
 
        if (cpuid == me) {
-               printk("%s: trying to call self\n", __FUNCTION__);
+               printk(KERN_WARNING "%s: trying to call self with info:%08x\n", 
__FUNCTION__, info);
                put_cpu();
                return -EBUSY;
        }