Kirill Korotaev wrote:
>>>>>>> "akpm" == akpm  <[EMAIL PROTECTED]> writes:
>>
>> akpm> From: Kirill Korotaev <[EMAIL PROTECTED]> It does not return NULL
>> akpm> when arg is NULL.
>>
>> Shouldn't the real fix be to track down who calls virt_to_page() with
>> a NULL pointer? IMHO it is bogus to do so.
> what do you propose? to insert BUG_ON(!kaddr) into virt_to_page()?
> in this case caller in question should be still fixed.

If you hit this, yes I'd insert the BUG_ON in your test kernel and fix
the code. Maybe add the BUG_ON in upstream for CONFIG_DEBUG or
something.

Which callers did you see cause this? If it was a common problem I would
expect a lot of data corruption or crashes on ia64 systems which I
haven't heard of.

Cheers,
Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to