On Tuesday 04 December 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > This belongs to user-space (and only if really needed).
>
> Sigh, and why only I spent time fixing this code? :-)
>
> > text data bss dec hex filename
> > 3874 180 28 4082 ff2 drivers/ide/pci/cmd64x.o.before
> > 2231 180 0 2411 96b drivers/ide/pci/cmd64x.o.after
>
> > Additionaly to being bloat the code contained two bugs:
> > - incorrect UDMA modes were reported for reserved values of UDIDETCR0/1 regs
>
> Huh? What reserved values?
According to CMD649 datasheet (rev 1.0):
register 73h
bit [5:4] and bit [7:6]
00 value is Reserved if bit[2] is 0
11 value is Reserved if bit[2] is 1
[ in CMD648 datasheet above values are listed as a valid timings but
they doesn't match UDMA modes reported by /proc/ide/cmd64x anyway ]
> > - MRDMODE_BLK_CH0/1 bits are not defined on CMD643 and early CMD646
> > revisions
>
> They're 0 there anyway, so the code worked properly.
Thanks, I removed this from the patch desription.
PS please don't fix /proc code in alim15x3.c ;-)
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
