Hi Qiao,
On Fri, Jul 13, 2012 at 04:32:43PM +0800, Qiao Zhou wrote:
> +
> + ret = regmap_read(info->map, PM800_STATUS_1, &val);
> + if (ret < 0) {
> + pr_err("%s: failed to read status: %d\n", __func__, ret);
Please change this to
dev_err(input_dev->dev.parent, "...")
so that error messages are consistent throughout your driver.
> +
> +static int __devexit pm80x_onkey_remove(struct platform_device *pdev)
> +{
> + struct pm80x_onkey_info *info = platform_get_drvdata(pdev);
> +
> + pm80x_free_irq(info->pm80x, info->irq, info);
> + input_unregister_device(info->idev);
> + kfree(info);
And add
device_init_wakeup(&pdev->dev, 0);
Otherwise feel free to add
Acked-by: Dmitry Torokhov <[email protected]>
and merge with the rest of the patches (I assume they went through MFD
tree?).
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
