Hi Ashish, On Thu, Oct 11, 2012 at 04:15:16PM +0530, Ashish Jangam wrote: > This is the ONKEY driver of the Dialog DA9055 PMIC and depends on the DA9055 > MFD > core driver. > > This patch is functionally tested on SMDK6410 board. > > Signed-off-by: David Dajun Chen <[email protected]> > Signed-off-by: Ashish Jangam <[email protected]> > --- > changes since v3: > - used of module_platform_driver macro > - add regmap virtual irq function > changes since v2: > - add support for button release > - use of devm_request_threaded_irq API
This API does not make any sense for your driver as you are scheduling delayed work from the IRQ handler. In such cases you need _first_ free IRQ and _then_ cancel the work but with devm_* you do it in opposite order. Also, I think I mentioned this before - this driver looks like twin brother for da9055_onkey.c. How many of such parts do you have (or will you have)? Is there way to unify them? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
