On Fri, Oct 12, 2012 at 5:55 PM, Daniel Mack <[email protected]> wrote:

> This allows DT driven boards to allocate and configure the pinmux once
> the driver is probed.
>
> Signed-off-by: Daniel Mack <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Dmitry Torokhov <[email protected]>

(...)
> +       /* request pin mux */
> +       pinctrl = devm_pinctrl_get_select_default(dev);
> +       if (IS_ERR(pinctrl))
> +               dev_warn(dev, "pins are not configured from the driver\n");

I think dev_warn() is rather nasty to throw in here, dev_info() is OK.

However I suspect this driver could actually handle default, idle and sleep
states, especially after the runtime PM patches discussed elsewhere,
but that can be patched later.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to