Hi Alexander, On Wed, Nov 21, 2012 at 07:32:42PM +0400, Alexander Shiyan wrote: > This patch adds a new driver for the beeper controlled via GPIO pin. > The driver does not depend on the architecture and is positioned as > a replacement for the specific drivers that are used for this function, > for example drivers/input/misc/ixp4xx-beeper. > Since this patch is only RFC, comments are welcome.
This looks reasonable, but if it is to be a generic solution it should handle GPIOs that need sleep so you need to schedule a work item from event() and toggle gpio from there. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
