Alan Cox <[email protected]> wrote:

>On Wed, 23 Jan 2013 20:15:47 -0800
>Dmitry Torokhov <[email protected]> wrote:
>
>> Hi Alan,
>> 
>> On Wed, Jan 23, 2013 at 05:38:43PM +0000, Alan Cox wrote:
>> > From: Brian Swetland <[email protected]>
>> > 
>> > This device is a direct pipe from "hardware" to the input
>> > event subsystem, allowing us to avoid having to route
>> > "keypad" style events through an AT keyboard driver (gross!)
>> > 
>> > As with the other submissions this driver is cross architecture.
>> > 
>> > Signed-off-by: Mike A. Chan <[email protected]>
>> > [Tided up to work on x86]
>> > Signed-off-by: Sheng Yang <[email protected]>
>> > Signed-off-by: Yunhong Jiang <[email protected]>
>> > Signed-off-by: Xiaohui Xin <[email protected]>
>> > Signed-off-by: Jun Nakajima <[email protected]>
>> > Signed-off-by: Bruce Beare <[email protected]>
>> > [Ported to 3.4]
>> > Signed-off-by: Tom Keel <[email protected]>
>> > [Cleaned up for 3.7 and submission]
>> > Signed-off-by: Alan Cox <[email protected]>
>> 
>> I do not have drivers/tty/goldfish.c so I dropped that change... I
>> also had a few more cleanups, the result is below.
>
>Looks good to me - I wasn't sure about the remove method so I copied
>the other keyboard drivers that still had one even though they used
>devm_ methods for the allocation.
>

Probably because some other resources are not devm managed and we need to 
preserve order. Or maybe just bugs...


Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to