Hello, > Furthermore, this patch has the effect of only applying blen and > tchthr when voltage is present. > If this is a 224 device, but the platform data does not specify > voltage (say, we are ok with the existing value loaded from NVRAM), > then we won't apply blen and tchthr either.
I think all those specific settings in handle_pdata() should be removed altogether: burst length is only the upper 4 bits actually; for the touchscreen threshold I think there are additional registers elsewhere which should be kept in sync expect not using pdata at all, there is no way to NOT make these settings I think there are other places (on the mxt224e) as well where the orientation has to be set, so pdata->orient setting MXT_TOUCH_MULTI_T9@MXT_TOUCH_ORIENT is only half of the story, you still need correct pdata->config and pdata->orient is basically useless the idea of the patch was to preserve the behaviour on the mxt224 but disable at least those two dubious settings; clearly not perfect > On Wed, Feb 20, 2013 at 10:29 AM, Yufeng Shen <[email protected]> wrote: > > On Thu, Feb 7, 2013 at 9:17 AM, Peter Meerwald <[email protected]> wrote: > >> /* Set touchscreen voltage */ > >> if (pdata->voltage && data->info.family_id == MXT224_ID) { > > > > As Benson noted in patch 5, what about the device that is neither 224 > > nor 224E ? burst length > > and threshold will no longer be applied. regards, p. -- Peter Meerwald +43-664-2444418 (mobile) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
