On Tue, Mar 5, 2013 at 12:01 PM, Ming Lei <[email protected]> wrote: > This patch adds comments on interface driver suspend callback > to emphasize that the failure return value is ignored by > USB core in system sleep context, so do not try to recover > device for this case. > > Signed-off-by: Ming Lei <[email protected]> > --- > include/linux/usb.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/linux/usb.h b/include/linux/usb.h > index 4d22d0f..ea9d7cb 100644 > --- a/include/linux/usb.h > +++ b/include/linux/usb.h > @@ -978,7 +978,10 @@ struct usbdrv_wrap { > * the "usbfs" filesystem. This lets devices provide ways to > * expose information to user space regardless of where they > * do (or don't) show up otherwise in the filesystem. > - * @suspend: Called when the device is going to be suspended by the system. > + * @suspend: Called when the device is going to be suspended by the > + * system either from system sleep or runtime suspend context, and > + * its failed return value will be ignored in system sleep context, > + * so do NOT try to recover device for this case. > * @resume: Called when the device is being resumed by the system. > * @reset_resume: Called when the suspended device has been reset instead > * of being resumed.
On the other hand, resume()/reset_resume() should deal with the previous suspend failure if the policy to ignore suspend failure is kept. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
