Hi Matteo, On Wed, Aug 14, 2013 at 11:37:17AM +0200, Matteo Delfino wrote: > The signatures of v3 and v4 packets change depending on the value of a > hardware flag called 'crc_enabled'. The packet type detection must change > accordingly. > > This patch also restores a consistency check for v4 packets inadvertently > removed by commit: > > 9eebed7de660c0b5ab129a9de4f89d20b60de68c > Input: elantech - fix for newer hardware versions (v7) > > A note about the naming convention: v3 hardware is associated with IC body > v5 while v4 hardware is associated with IC body v6 and v7. The above commit > refers to IC body v7, not to v7 hardware. > > Tested on Samsung NP730U3E (fw = 0x675f05, ICv7, crc_enabled = 1) > > Tested-by: Giovanni Frigione <[email protected]> > Signed-off-by: Matteo Delfino <[email protected]> > --- > > Hello Dmitry, > this patch is based on some information provided by elantech. It has > been successfully tested on the above v4 hardware so the information > seems to be reliable. More testing is needed on v3 hardware with > crc_enabled=1 (if there's such hardware out there..). The behaviour > should be unchanged for v3 and v4 hardware with crc_enabled=0 (the > vast majority). > > I was asked to CC stable kernels too since this patch restores a > consistency check on v4 packets removed by a previous commit already > queued in linux-3.5.y-queue but, considering the above, I think it's > best to leave this decision to you.
Once again, I think it should bake a bit in the trees before heading for next, so I won't mark it for stable. Feel free to forward it later, once it survives a few -rcs. Thanks! -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
