Wei Yongjun <[email protected]> wrote: >From: Wei Yongjun <[email protected]> > >The dereference should be moved below the NULL test. > >Signed-off-by: Wei Yongjun <[email protected]> >--- > drivers/input/touchscreen/cyttsp4_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/input/touchscreen/cyttsp4_core.c >b/drivers/input/touchscreen/cyttsp4_core.c >index 963da05..ffa8e35 100644 >--- a/drivers/input/touchscreen/cyttsp4_core.c >+++ b/drivers/input/touchscreen/cyttsp4_core.c >@@ -1244,11 +1244,11 @@ static void cyttsp4_watchdog_timer(unsigned >long handle) > { > struct cyttsp4 *cd = (struct cyttsp4 *)handle; > >- dev_vdbg(cd->dev, "%s: Watchdog timer triggered\n", __func__); >- > if (!cd) > return; >
Actually this test does not make any sense and we should rather remove it. >+ dev_vdbg(cd->dev, "%s: Watchdog timer triggered\n", __func__); >+ > if (!work_pending(&cd->watchdog_work)) > schedule_work(&cd->watchdog_work); > Hi Wei, Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
