On 06.09.2013 15:25, Benjamin Tissoires wrote:
> Some generic comments:
> - please always inline the code in the message, it is *much* easier to review
> and comment it
> - please directly use a patch format: if the code is good, Dmitry can take it
> directly through his tree
> - add the following people for further submissions:
> * Henrik - multitouch maintainer in the kernel, and I'm sure he will be
> happy to see this stuff
> * Dmitry - input maintainer, the driver will go through his tree, so it's
> better to let him know as soon as possible of the different discussions.
> - please stick to the kernel formatting guidelines (without orders: do not
> use C99-style ("// ..."), do not mix tabs and spaces, stick to 80 columns,
> etc..). The whole documentation is in Documentation/CodingStyle, and use the
> script scripts/checkpatch.pl to validate most of these.
> - I don't think a separate ".h" will be accepted as the declarations will not
> be used outside of the driver. Just merge the header on top of you .c file.Benjamin and David, thanks for your feedback. I will integrate this and get back to you with a proper patch ASAP. I have one additional question which is more about "future-proofing" this driver. The SUR40 hardware does also provide a raw video image from the touch sensor over another USB _endpoint_. Since it's not a different _interface_, this can only be handled in the same driver as far as I can tell. At some point in the future, I would like to add a V4L2 interface to also support the video endpoint - are there any issues I should already try to watch out for in the input part? Thanks again, and best regards, Florian -- SENT FROM MY DEC VT50 TERMINAL
signature.asc
Description: OpenPGP digital signature
