On Thu, Oct 24, 2013 at 02:42:13PM +0200, Denis Carikli wrote: > Cc: Rob Herring <[email protected]> > Cc: Pawel Moll <[email protected]> > Cc: Mark Rutland <[email protected]> > Cc: Stephen Warren <[email protected]> > Cc: Ian Campbell <[email protected]> > Cc: [email protected] > Cc: Dmitry Torokhov <[email protected]> > Cc: [email protected] > Cc: Sascha Hauer <[email protected]> > Cc: [email protected] > Cc: Lothar Waßmann <[email protected]> > Cc: Eric Bénard <[email protected]> > Signed-off-by: Denis Carikli <[email protected]> > --- > ChangeLog v6->v7: > - One small whitespace cleanup. > - The properties specific to that driver are now prefixed with "ti,". > - The ti,fuzzy property has now better documentation. > --- > .../bindings/input/touchscreen/tsc2007.txt | 45 +++++ > drivers/input/touchscreen/tsc2007.c | 194 > +++++++++++++++----- > 2 files changed, 198 insertions(+), 41 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt > b/Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt > new file mode 100644 > index 0000000..516b63b > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt > @@ -0,0 +1,45 @@ > +* Texas Instruments tsc2007 touchscreen controller > + > +Required properties: > +- compatible: must be "ti,tsc2007". > +- reg: I2C address of the chip. > +- ti,x-plate-ohms: X-plate resistance in ohms. > + > +Optional properties: > +- gpios: the interrupt gpio the chip is connected to (trough the penirq pin) > + (see GPIO binding[2] for more details). > +- interrupt-parent: the phandle for the gpio controller > + (see interrupt binding[1]). > +- interrupts: (gpio) interrupt to which the chip is connected > + (see interrupt binding[1]). > +- pinctrl-0: Should specify pin control groups used for the gpio > + (see pinctrl bindings[0]). > +- pinctrl-names: Should contain only one value - "default" > + (see pinctrl bindings[0]).
Also I haven't seen a response as to why this can't be handled by the GPIO driver. Adding Linus Walleij, perhaps he knows a more definitive answer. Linus, the issue here is that the pinctrl properties for this chip are supposed to pinmux the pendown GPIO for this chip. I was under the impression that this should be handled by the GPIO controller itself, so that when gpio_request() was called on a pin it would be the GPIO controller driver's responsibility to pinmux it appropriately. > +- ti,max-rt: maximum pressure. > +- ti,fuzzy: specifies the absolute input fuzz value. > + If set, it will permit noise in the data up to +- the value given to the > fuzz > + parameter, that is used to filter noise from the event stream. Any reason why these can't be specified per axis? From my experience with this chip it can make sense to use different values for the different axes. Well, perhaps X and Y axes can share one fuzz factor, but the Z axis is sometimes different. You also modify the driver to ignore the X and Z axes fuzz factor even for platform data where specifying all three separately was explicitly allowed. Have you verified that this doesn't cause any regressions? Thierry
pgpwskoXf1U1M.pgp
Description: PGP signature
