Hi, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 14:17 Fri 08 Nov , Denis Carikli wrote: > > Cc: Rob Herring <[email protected]> > > Cc: Pawel Moll <[email protected]> > > Cc: Mark Rutland <[email protected]> > > Cc: Stephen Warren <[email protected]> > > Cc: Ian Campbell <[email protected]> > > Cc: Grant Likely <[email protected]> > > Cc: [email protected] > > Cc: Dmitry Torokhov <[email protected]> > > Cc: [email protected] > > Cc: Sascha Hauer <[email protected]> > > Cc: [email protected] > > Cc: Lothar Waßmann <[email protected]> > > Cc: Shawn Guo <[email protected]> > > Cc: Eric Bénard <[email protected]> > > Signed-off-by: Denis Carikli <[email protected]> > > --- > > ChangeLog v8->v9: > > - Added Grant Likely in the cc list. > > - Adapted to the removal of the pinctrl properties in the tsc2007 > > documentation. > > - Fixed the gpios property (before, it was set to active high by error). > > > > ChangeLog v7->v8: > > - Added Shawn Guo in the cc list. > > --- > > arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi > > b/arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi > > index b9cb5a5..f25a40f 100644 > > --- a/arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi > > +++ b/arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi > > @@ -36,6 +36,27 @@ > > compatible = "nxp,pcf8563"; > > reg = <0x51>; > > }; > > + > > + tsc2007: tsc2007@48 { > > + compatible = "ti,tsc2007"; > > + reg = <0x48>; > > + interrupt-parent = <&gpio3>; > > + interrupts = <0x2 0x8>; > > + gpios = <&gpio3 2 1>; > as explain on the binding drop this gpios this is an IRQ not a gpio > > NACK The driver needs an interrupt to get notified about pendown events and needs to poll the pendown signal to find out when the pen has been lifted. Both the interrupt and the pendown signal happen to be signalled on the same pin. Thus, IMO it is perfectly well to have the interrupt property as well as the gpios property here.
How would you tell the driver which pin to poll for detecting the pen up event? Having a platform callback with hardcoded GPIO numbers is not an option. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | [email protected] ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
