Hi Dmitry, Thanks for your review.
2013/12/2 Dmitry Torokhov <[email protected]>: >> + /* Ignore stick point data */ >> + if (packet[0] == 0xD8) >> + return; > Why are we ignoring trackstick data? If there Dolphin models with > tracksticks that would basically "break" the device for users compared > withe the emulated Explorer PS/2 mode. I'm sorry, I think I used the wrong comment here... Use comment /* Check if it's an valid touchpad packet */ would be better >From the V5's spec, "0xC8" is the checkmask for 6byte Raw mode and 0x10 is the mask for trackpoint's / touchpad's packet. So, 0xC8 means current packet is from touchpad and 0xD8 for trackpoint. In current source code, what I wanted to do is just add a protection logic to double check if it's a valid touchpad packet. About your concern, I think there would be no problem because: 1) In initialization, we did not initialize trackpoint device as Raw mode and it should always report 3Byte-packet. And in the first of alps_process_byte(), 3byte packet would be processed separately. 2) I checked with my Japanese colleague and in fact, there is no V5 device with trackpoint + touchpad in the world, although V5's spec designed the case of trackpoint's packet. Thanks -- Best Regards, Tommy -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
