On Sat, Mar 08, 2014 at 03:29:54AM +0100, Christopher Heiny wrote: > Reflash functionality will need to unload the existing functions and > rescan the PDT before starting reflash; then reload the functions > afterwards. > > Signed-off-by: Christopher Heiny <[email protected]> > Signed-off-by: Vincent Huang <[email protected]> > Cc: Dmitry Torokhov <[email protected]> > Cc: Benjamin Tissoires <[email protected]> > Cc: Linux Walleij <[email protected]> > Cc: David Herrmann <[email protected]> > Cc: Jiri Kosina <[email protected]> > > --- > > drivers/input/rmi4/rmi_driver.c | 165 > ++++++++++++++++++++++------------------ > drivers/input/rmi4/rmi_driver.h | 22 +++--- > 2 files changed, 101 insertions(+), 86 deletions(-) [...] > diff --git a/drivers/input/rmi4/rmi_driver.h b/drivers/input/rmi4/rmi_driver.h [...] > -int rmi_read_pdt_entry(struct rmi_device *rmi_dev, struct pdt_entry *entry, > - u16 pdt_address); > +#define RMI_SCAN_CONTINUE 0 > +#define RMI_SCAN_DONE 1 > + > +int rmi_scan_pdt(struct rmi_device *rmi_dev, void *ctx, > + int (*callback)(struct rmi_device *rmi_dev, > + void *ctx, const struct pdt_entry *entry));
I don't really like this callback. The main reason for it is early abort of PDT scanning, right? It is really that beneficial? > > bool rmi_is_physical_driver(struct device_driver *); > int rmi_register_physical_driver(void); > @@ -113,4 +109,10 @@ void rmi_unregister_physical_driver(void); > int rmi_register_f01_handler(void); > void rmi_unregister_f01_handler(void); > > +int check_bootloader_mode(struct rmi_device *rmi_dev, > + const struct pdt_entry *pdt); This is a silly function name to put in a header. rmi_* perhaps? > +void rmi_free_function_list(struct rmi_device *rmi_dev); > +int rmi_driver_detect_functions(struct rmi_device *rmi_dev); > + > + > #endif -Courtney -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
