On Wed, Apr 23, 2014 at 2:04 AM, Dmitry Torokhov
<[email protected]> wrote:
> On Mon, Apr 07, 2014 at 09:49:52AM +0200, Jiri Kosina wrote:
>> > +#define KEY_BRIGHTNESS             0x250   /* Display Brightness */
>
> What is it supposed to do exactly? Show OSD for brightness?

No, it's a linear control usage to (HUTTR41) "Sets brightness to a
value between logical min and max.". I'm changing the comment to /*
Set Brightness */.

>> > +#define KEY_BRIGHTNESS_TOGGLE              0x251   /* Backlight Toggle */
>
> We already have KEY_DISPLAYTOGGLE, isn't this the same?

I agree, they are the same and we should alias it to
KEY_DISPLAYTOGGLE. I'm sending a v2 patch.

Best regards,

Olivier
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to