Mon, 28 Apr 2014 19:21:04 -0700 от Dmitry Torokhov <[email protected]>: > Hi Alexander, > > On Sat, Apr 26, 2014 at 09:46:54AM +0400, Alexander Shiyan wrote: > > + beep->desc = devm_gpiod_get(&pdev->dev, NULL); > > + if (!beep->desc) > > + return -EINVAL; > > As far as I can see devm_gpiod_get() never returns NULL, but either a > valid pointer or ERR_PTR-encoded error. Why do we check for NULL? > > I can drop the check myself, no need to resubmit.
OK. ... One issue you keep value argument for gpio_beeper_toggle() as bool. It should be "int" as in original patch, as well as "beeping" value in private struct. ---
