On Wed, 3 Sep 2014, Benjamin Tissoires wrote: > > From: Benjamin Tissoires <[email protected]> > > Date: Tue, 2 Sep 2014 15:50:43 -0400 > > Subject: [PATCH] HID: thingm: set the proper error code before leaving > > > > In case of an unsupported firmware, the driver bails out without setting > > the LEDs interfaces, but forget to set the proper error code. > > err is then still equal to 0 and the hid subsytem consider the device > > to be in perfect shape. > > When removing it, thingm_remove() tries to unbind the rgb LEDs which > > has not been created, leading to a segfault. > > > > Signed-off-by: Benjamin Tissoires <[email protected]> > > --- > > drivers/hid/hid-thingm.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/hid/hid-thingm.c b/drivers/hid/hid-thingm.c > > index 134be89..f91f971 100644 > > --- a/drivers/hid/hid-thingm.c > > +++ b/drivers/hid/hid-thingm.c > > @@ -250,6 +250,7 @@ static int thingm_probe(struct hid_device *hdev, const > > struct hid_device_id *id) > > > > if (!tdev->fwinfo) { > > hid_err(hdev, "unsupported firmware %c\n", > > tdev->version.major); > > + err = -ENODEV; > > goto stop; > > } > > Jiri, could you still consider including this one? If Thingm decides > to create a firmware with 3.X, it will fail, so I guess this is still > required, even if it does not fix Dylan's problem.
It's now queued in for-3.17/upstream-fixes. I don't think it justifies pull request to Linus by itself, but if there is anything else that does, it'll piggy-back. Otherwise it'll go into 3.18. Please shout if it's not okay. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
